app: harden mirroring lifecycle and state

1 files changed, 13 insertions, 3 deletions

diff --git a/app/src/test/java/invalid/lena/scrcpy/DevicesTest.java b/app/src/test/java/invalid/lena/scrcpy/DevicesTest.java
index dcd04ca..bde8af8 100644
--- a/app/src/test/java/invalid/lena/scrcpy/DevicesTest.java
+++ b/app/src/test/java/invalid/lena/scrcpy/DevicesTest.java
@@ -2,6 +2,7 @@ package invalid.lena.scrcpy;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
@@ -20,9 +21,10 @@ public class DevicesTest {
     }
 
     @Test
-    public void parseNonArrayReturnsEmpty() {
-        assertTrue(Devices.parse("{not json").isEmpty());
-        assertTrue(Devices.parse("{\"host\":\"x\"}").isEmpty());
+    public void parseNonArrayFailsLoudly() {
+        assertThrows(IllegalArgumentException.class, () -> Devices.parse("{not json"));
+        assertThrows(IllegalArgumentException.class,
+                () -> Devices.parse("{\"host\":\"x\"}"));
     }
 
     @Test
@@ -54,6 +56,14 @@ public class DevicesTest {
     }
 
     @Test
+    public void serializeRejectsInvalidRows() {
+        assertThrows(IllegalStateException.class, () -> Devices.serialize(Arrays.asList(
+                new Devices.Device("bad host", 5555))));
+        assertThrows(IllegalStateException.class, () -> Devices.serialize(Arrays.asList(
+                new Devices.Device("target", 0))));
+    }
+
+    @Test
     public void parseAddressSplitsHostAndPort() {
         Devices.Device d = Devices.parseAddress("  192.168.1.42:41234 ");
         assertEquals("192.168.1.42", d.host);