From 3cc5eff7d8d4b9a33633b99e2a82d3df8cdfd4d6 Mon Sep 17 00:00:00 2001 From: Lena Date: Wed, 1 Jul 2026 00:00:00 +0000 Subject: app: report whether a recording was actually written MuxRecorder had a Listener interface that nothing implemented; every callback fired into a no-op. Delete it. stop() now returns whether a keyframe ever landed and the muxer ran, so Mirror can stop claiming "recording saved" when no file was written. --- app/src/main/java/invalid/lena/scrcpy/Mirror.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'app/src/main/java/invalid/lena/scrcpy/Mirror.java') diff --git a/app/src/main/java/invalid/lena/scrcpy/Mirror.java b/app/src/main/java/invalid/lena/scrcpy/Mirror.java index f6e249d..2c361da 100644 --- a/app/src/main/java/invalid/lena/scrcpy/Mirror.java +++ b/app/src/main/java/invalid/lena/scrcpy/Mirror.java @@ -260,8 +260,11 @@ public final class Mirror extends Activity { private void toggleRecord() { if (session == null) return; if (session.isRecording()) { - session.stopRecording(); - Toast.makeText(this, "recording saved", Toast.LENGTH_SHORT).show(); + // stopRecording is false when no keyframe ever landed (still + // ARMED) - no file was written, so don't claim one was saved. + boolean saved = session.stopRecording(); + Toast.makeText(this, saved ? "recording saved" : "recording discarded (no video)", + Toast.LENGTH_SHORT).show(); } else { File dir = getExternalFilesDir(null); if (dir == null) { -- cgit v1.2.3